Disable Prometheus packet counters #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prometheus.CounterVec.Inc()and.Add()aren't implemented very efficiently and can cause to performances issues when they are called frequently. Since restreamer processes each transport stream packet individually, Inc() and Add() are called for every incoming and outgoing packet. This leads to many more drops than processing only the packets would need.The built-in performance counters don't have this issue, because they use atomic variables directly instead of locks or channels
For this reason, I'm disabling the Prometheus packet counters. Since these counters are still useful, a more efficient solution should be found.