Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported ops: TensorScatterAdd, TensorListConcatV2, Rank #1778

Closed
igalkr opened this issue Nov 18, 2021 · 10 comments
Closed

Unsupported ops: TensorScatterAdd, TensorListConcatV2, Rank #1778

igalkr opened this issue Nov 18, 2021 · 10 comments
Assignees
Labels
pending on user response Waiting for more information or validation from user unsupported ops Issues related to unsupported operators

Comments

@igalkr
Copy link

igalkr commented Nov 18, 2021

Hi, are the above ops to be supported, or am I running the command incorrectly?
python -m tf2onnx.convert --saved-model saved_model --output model.onnx -v --target tensorrt --tag serve

@alexarmbr
Copy link

I am having a very confusing problem with tf2onnx giving me TensorScatterAdd nodes. The tf code I am trying to convert to onnx used tf.tensor_scatter_nd_add. I replaced this with tf.scatter_nd and tf.math.add in the hopes that tf2onnx would stop giving me this TensorScatterAdd node, but I am still getting it. It is almost as if tf2onnx is fusing these two operations for me.

More generally, I am confused why the tf2onnx parser is giving me a node that is not supported by onnx. I would love an explanation of what is going on here!

@guschmue
Copy link
Contributor

Yes, TensorScatterAdd, TensorListConcatV2 are not mapped - we'd need to add it.

@igalkr
Copy link
Author

igalkr commented Nov 25, 2021

What should I do in the meantime? I really need the onnx converted file.

@fatcat-z
Copy link
Collaborator

fatcat-z commented Dec 6, 2021

What should I do in the meantime? I really need the onnx converted file.

Could you please share the TF code of your model so that we can validate it once there is a fix?

@fatcat-z fatcat-z added the pending on user response Waiting for more information or validation from user label Dec 6, 2021
@fatcat-z fatcat-z self-assigned this Dec 6, 2021
@hwangdeyu hwangdeyu added the unsupported ops Issues related to unsupported operators label Dec 14, 2021
@igalkr
Copy link
Author

igalkr commented Jan 2, 2022

Hi,
I had to get in contact with our management, we cannot share the code at the moment.

@r-remus
Copy link

r-remus commented Mar 25, 2022

👍 I'd really like to see TensorScatterAdd be added to tf2onnx as well.

@hwangdeyu
Copy link
Contributor

Hi @r-remus @igalkr, thanks for your comments!
TensorScatterAdd has added with this PR Add TensorScatterAdd op for opset 16.
You can try to convert it using latest main branch code or waitting for the next tf2onnx release.

@fatcat-z
Copy link
Collaborator

It's been over 2 months, so closing this. Feel free to open a new one if the issue still exists.

@k-maheshkumar
Copy link

Hi, I am getting the following error with opset=18:

Tensorflow op [TensorListConcatV2_4: TensorListConcatV2] is not supported
Tensorflow op [TensorListConcatV2_3: TensorListConcatV2] is not supported
Tensorflow op [TensorListConcatV2_2: TensorListConcatV2] is not supported
Tensorflow op [TensorListConcatV2_1: TensorListConcatV2] is not supported
Tensorflow op [TensorListConcatV2: TensorListConcatV2] is not supported
Unsupported ops: Counter({'TensorListConcatV2': 5})

could you please help me?

@fatcat-z
Copy link
Collaborator

Hi, I am getting the following error with opset=18:

Tensorflow op [TensorListConcatV2_4: TensorListConcatV2] is not supported Tensorflow op [TensorListConcatV2_3: TensorListConcatV2] is not supported Tensorflow op [TensorListConcatV2_2: TensorListConcatV2] is not supported Tensorflow op [TensorListConcatV2_1: TensorListConcatV2] is not supported Tensorflow op [TensorListConcatV2: TensorListConcatV2] is not supported Unsupported ops: Counter({'TensorListConcatV2': 5})

could you please help me?

This op is not supported yet. Please feel free to open a new issue with some details, like code or model, for this requirement so that we can put it into the plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending on user response Waiting for more information or validation from user unsupported ops Issues related to unsupported operators
Projects
None yet
Development

No branches or pull requests

7 participants