Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback components to selected part of the UI #1247

Open
sarathms opened this issue Sep 8, 2020 · 2 comments
Open

Add fallback components to selected part of the UI #1247

sarathms opened this issue Sep 8, 2020 · 2 comments
Assignees
Labels
discuss invites discussion from contributors ooni/probe-desktop priority/medium ux

Comments

@sarathms
Copy link

sarathms commented Sep 8, 2020

While researching solutions for #1245, I came across react-error-boundary which provides an API to setup fallback UI to mount when the app encounters runtime errors in renders. It doesn't make sense to use it at very granular level like in the below example, but it might be useful to implement at a higher level and provide a graceful way to recover when test results contain unexpected values or expected values are absent. Of course, some UX brainstorming is needed to identify which parts of UI warrant a fallback version.

Stable UI
image.png

Fallback component (only contains a simple string here) when any of the 4 values in the columns throw unhandled exceptions.
image.png

@hellais
Copy link
Member

hellais commented Nov 3, 2020

This may also be relevant to Explorer

@sarathms
Copy link
Author

sarathms commented Nov 4, 2020

Related issue for explorer: ooni/explorer#516

@hellais hellais removed the discuss invites discussion from contributors label Jul 14, 2021
@hellais hellais added the discuss invites discussion from contributors label Jul 14, 2021
@hellais hellais removed this from the Sprint 50 - Amphipoda milestone Oct 25, 2021
@hellais hellais removed the effort/L label Jan 31, 2022
@bassosimone bassosimone assigned majakomel and unassigned sarathms Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss invites discussion from contributors ooni/probe-desktop priority/medium ux
Projects
None yet
Development

No branches or pull requests

4 participants