Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to_feature_generator to ColumnGenerator #79

Closed
MischaPanch opened this issue Feb 27, 2024 · 1 comment · Fixed by #86
Closed

Add to_feature_generator to ColumnGenerator #79

MischaPanch opened this issue Feb 27, 2024 · 1 comment · Fixed by #86
Assignees
@MischaPanch

Comments

@MischaPanch
Copy link
Collaborator

We can prevent circular imports by importing at TYPE_CHECKING time.

@opcode81 do you agree that it's a useful feature? Now the user would have to know that the class FeatureGeneratorFromColumnGenerator exists
@MischaPanch MischaPanch self-assigned this Feb 27, 2024
@opcode81
Copy link
Owner

Yes, let's add it.

@MischaPanch MischaPanch mentioned this issue Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MischaPanch MischaPanch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor improvements opcode81/sensAI
2 participants
@opcode81 @MischaPanch