Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: save additional values to mps db #1100

Merged
merged 4 commits into from
Oct 17, 2023
Merged

feat: save additional values to mps db #1100

merged 4 commits into from
Oct 17, 2023

Conversation

rjbrache
Copy link
Contributor

@rjbrache rjbrache commented Oct 6, 2023

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (cd69c99) 94.46% compared to head (7f27235) 94.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1100   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files          83       83           
  Lines        3525     3525           
  Branches      603      603           
=======================================
  Hits         3330     3330           
  Misses        189      189           
  Partials        6        6           
Files Coverage Δ
src/data/postgres/tables/device.ts 100.00% <ø> (ø)
src/models/models.ts 100.00% <ø> (ø)
src/routes/devices/deviceValidator.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjbrache rjbrache changed the title fix: fixed mongo device deletion feat: save additional values to mps mongo db Oct 11, 2023
@rjbrache rjbrache force-pushed the devicedata_1164 branch 2 times, most recently from f611148 to d011490 Compare October 12, 2023 22:05
@rjbrache rjbrache changed the title feat: save additional values to mps mongo db feat: save additional values to mps db Oct 13, 2023
@rjbrache rjbrache merged commit ea2c973 into main Oct 17, 2023
12 checks passed
@rjbrache rjbrache deleted the devicedata_1164 branch October 17, 2023 22:35
@github-actions
Copy link

🎉 This PR is included in version 2.12.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants