Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add dnssuffix to api tests #1124

Merged
merged 1 commit into from
Oct 18, 2023
Merged

test: add dnssuffix to api tests #1124

merged 1 commit into from
Oct 18, 2023

Conversation

rjbrache
Copy link
Contributor

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ea2c973) 94.46% compared to head (c5fffd8) 94.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1124   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files          83       83           
  Lines        3525     3525           
  Branches      603      603           
=======================================
  Hits         3330     3330           
  Misses        189      189           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjbrache rjbrache requested a review from rsdmike October 17, 2023 23:29
@rjbrache rjbrache marked this pull request as ready for review October 18, 2023 15:37
@rjbrache rjbrache merged commit 223d2f0 into main Oct 18, 2023
12 checks passed
@rjbrache rjbrache deleted the storeDnsSuffix branch October 18, 2023 15:38
@github-actions
Copy link

🎉 This PR is included in version 2.12.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants