fix(config): removed use_allowlist from config #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhavilosetty-intel
force-pushed
the
remove-allowlist-flag
branch
3 times, most recently
from
83b7c19
to
9a5c819
Compare
madhavilosetty-intel
force-pushed
the
remove-allowlist-flag
branch
from
9a5c819
to
a60995a
Compare
brianosburn-intel
approved these changes
Jun 8, 2021
rsdmike
approved these changes
Jun 8, 2021
| @@ -25,10 +25,8 @@ To deploy the MPS on a local development system: | |||
| git clone https://github.com/open-amt-cloud-toolkit/mps.git && cd mps | |||
| ``` | |||
|
|
|||
| 2. Modify the mps/.mpsrc file’s allowlist and common name settings. Save and close the file. | |||
| 2. Modify the mps/.mpsrc file common name settings. Save and close the file. | |||
There was a problem hiding this comment.
Make sure this is updated in the docs repo
| @@ -8,7 +8,7 @@ | |||
| Functionality has been modified for standalone operation only (Meshcentral services will not work with this code) | |||
| Parameters: | |||
| parent (mpsMicroservice): parent service invoking this module (provides eventing and wiring services) | |||
| db: database for credential and allowlisting | |||
| db: database for credential | |||
| @@ -67,66 +65,23 @@ export class SecretsDbProvider implements IDbProvider { | |||
| const amtpass = data.data.AMT_PASSWORD | |||
| return [user, amtpass] | |||
| } catch (error) { | |||
| this.logger.error('Error while retrieving device credentials\r\n') | |||
| this.logger.error(error) | |||
| this.logger.error('Error while retrieving device credentials :', error) | |||
| return null | |||
| } | |||
| } | |||
|
|
|||
| async IsGUIDApproved (guid: string, cb: any): Promise<void> { | |||
There was a problem hiding this comment.
i'd like to start to "generazing" the vaultDbProvider a bit, so, in essence should the function simple be "GetDevice Secret()" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, includes fix for below:
2021-06-07T18:28:51.526Z error: getSecretFromKey error
2021-06-07T18:28:51.527Z error: Status 404