Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(auth): Auth updates #238

Merged
merged 2 commits into from
Jun 11, 2021
Merged

refactor(auth): Auth updates #238

merged 2 commits into from
Jun 11, 2021

Conversation

brianosburn-intel
Copy link
Contributor

No description provided.

@madhavilosetty-intel madhavilosetty-intel force-pushed the auth_updates branch 3 times, most recently from 4f4dbad to 2c98342 Compare June 9, 2021 22:51
rsdmike
rsdmike requested changes Jun 9, 2021
View reviewed changes
src/routes/auth/login.ts Outdated Show resolved Hide resolved
src/routes/auth/login.ts Outdated Show resolved Hide resolved
src/routes/devices/deviceValidator.ts Show resolved Hide resolved
src/test/helper/db.ts
@@ -136,11 +135,10 @@ export class Database implements IDbProvider {
try {
let result = false
const cred = this.getCredentialsForGuid(guid)
log.info(cred)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for removing this! 👍

src/utils/AuthDbProvider.ts Outdated Show resolved Hide resolved
@madhavilosetty-intel
refactor(auto): check for jwt secret and mps credentials
c9fa298 
BREAKING CHANGES: db schema changed to accept mps username
@rsdmike rsdmike marked this pull request as ready for review June 10, 2021 17:45
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2021 •
edited
Loading

Codecov Report

Merging #238 (d71b765) into master (66ace69) will decrease coverage by 0.00%.
The diff coverage is 56.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   26.65%   26.65%   -0.01%     
==========================================
  Files          52       53       +1     
  Lines        3429     3433       +4     
  Branches      653      652       -1     
==========================================
+ Hits          914      915       +1     
- Misses       2235     2238       +3     
  Partials      280      280
Impacted Files Coverage Δ
src/db/device.ts 10.34% <0.00%> (ø)
src/db/mapToDevice.ts 50.00% <ø> (ø)
src/routes/devices/create.ts 17.85% <0.00%> (-0.67%) ⬇️
src/routes/devices/deviceValidator.ts 100.00% <ø> (ø)
src/test/helper/ciraclient.js 88.06% <ø> (ø)
src/test/helper/common.js 59.57% <ø> (ø)
src/routes/auth/login.ts 20.00% <9.09%> (+1.81%) ⬆️
src/server/mpsserver.ts 38.29% <64.28%> (-0.30%) ⬇️
src/routes/auth/authValidator.ts 100.00% <100.00%> (ø)
src/routes/index.ts 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66ace69...d71b765. Read the comment docs.

@madhavilosetty-intel madhavilosetty-intel merged commit 74ad9fc into master Jun 11, 2021
@madhavilosetty-intel madhavilosetty-intel deleted the auth_updates branch June 11, 2021 20:10
@brianosburn-intel brianosburn-intel linked an issue Jun 15, 2021 that may be closed by this pull request
"Error while retrieving guids allowlist" on device connect when MPS_USE_ALLOWLIST=true #188
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsdmike rsdmike rsdmike approved these changes

@madhavilosetty-intel madhavilosetty-intel Awaiting requested review from madhavilosetty-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Error while retrieving guids allowlist" on device connect when MPS_USE_ALLOWLIST=true
4 participants
@brianosburn-intel @codecov-commenter @madhavilosetty-intel @rsdmike