Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add endpoint to remotely unprovision devices #720

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

matt-primrose
Copy link
Member

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

@matt-primrose matt-primrose changed the title feat(api): added deactivate @matt-primrose feat(api): add endpoint to unprovision devices Nov 7, 2022
@matt-primrose matt-primrose changed the title @matt-primrose feat(api): add endpoint to unprovision devices feat(api): add endpoint to unprovision devices Nov 7, 2022
@matt-primrose matt-primrose enabled auto-merge (rebase) November 7, 2022 22:18
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #720 (cb8e2bd) into main (2ed9280) will decrease coverage by 0.24%.
The diff coverage is 65.51%.

@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
- Coverage   93.60%   93.35%   -0.25%     
==========================================
  Files          77       78       +1     
  Lines        3253     3282      +29     
  Branches      523      526       +3     
==========================================
+ Hits         3045     3064      +19     
- Misses        208      218      +10     
Impacted Files Coverage Δ
src/amt/DeviceAction.ts 90.20% <0.00%> (-1.55%) ⬇️
src/secrets/vault/index.ts 90.74% <0.00%> (-9.26%) ⬇️
src/logging/messages.ts 100.00% <100.00%> (ø)
src/routes/amt/deactivate.ts 100.00% <100.00%> (ø)
src/routes/amt/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rsdmike rsdmike changed the title feat(api): add endpoint to unprovision devices feat(api): add endpoint to remotely unprovision devices Nov 7, 2022
auto-merge was automatically disabled November 7, 2022 22:23

Rebase failed

@rsdmike rsdmike merged commit 6cab674 into main Nov 7, 2022
@rsdmike rsdmike deleted the deactivation-new branch November 7, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants