Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Device deletion request from RPS #886

Merged
merged 3 commits into from
May 3, 2023
Merged

Conversation

rjbrache
Copy link
Contributor

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #886 (8cb0428) into main (1c35806) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files          78       78           
  Lines        3330     3331    +1     
  Branches      569      570    +1     
=======================================
+ Hits         3144     3145    +1     
  Misses        179      179           
  Partials        7        7           
Impacted Files Coverage Δ
src/routes/devices/delete.ts 100.00% <100.00%> (ø)

@rjbrache rjbrache force-pushed the multitenancy_deactivation branch from 301c7c0 to 8cb0428 Compare May 2, 2023 23:44
@rjbrache rjbrache marked this pull request as ready for review May 3, 2023 00:00
@rjbrache rjbrache merged commit dd483d6 into main May 3, 2023
@rjbrache rjbrache deleted the multitenancy_deactivation branch May 3, 2023 17:20
@matt-primrose matt-primrose linked an issue May 3, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants