Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configs to consul #982

Merged
merged 3 commits into from
Jul 31, 2023
Merged

feat: add configs to consul #982

merged 3 commits into from
Jul 31, 2023

Conversation

rjbrache
Copy link
Contributor

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #982 (0a088ff) into main (ca5aa89) will increase coverage by 0.04%.
The diff coverage is 97.91%.

@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
+ Coverage   94.66%   94.71%   +0.04%     
==========================================
  Files          79       81       +2     
  Lines        3395     3443      +48     
  Branches      578      582       +4     
==========================================
+ Hits         3214     3261      +47     
- Misses        175      176       +1     
  Partials        6        6              
Files Changed Coverage Δ
src/index.ts 58.09% <90.90%> (+3.83%) ⬆️
src/consul/consul.ts 100.00% <100.00%> (ø)
src/consul/serviceManager.ts 100.00% <100.00%> (ø)

@rjbrache rjbrache force-pushed the consul branch 5 times, most recently from 5793921 to 35bbab1 Compare July 28, 2023 23:23
@rjbrache rjbrache marked this pull request as ready for review July 31, 2023 05:19
@madhavilosetty-intel madhavilosetty-intel merged commit b2d1dd4 into main Jul 31, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants