Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for explicit http-proxying #1042

Open
Tracked by #1064
nicolasduczek opened this issue Nov 4, 2024 · 3 comments
Open
Tracked by #1064

Add support for explicit http-proxying #1042

nicolasduczek opened this issue Nov 4, 2024 · 3 comments
Labels
area/ipcei Important Project of Common European Interest component/ocm-cli OCM Command Line Interface component/ocm-core Open Component Model Core aka. go API kind/feature new feature, enhancement, improvement, extension
Milestone

Comments

@nicolasduczek
Copy link

nicolasduczek commented Nov 4, 2024

What would you like to be added:

Support should be added to enable (non-transparent) http-proxy as typically configured via HTTP_PROXY / HTTPS_PROXY environment variables in the form of

$https_proxy=http://user:password@ProxyIP:80
$http_proxy=http://user:password@ProxyIP:80

Why is this needed:

In order to access resources through a http-proxy

@nicolasduczek nicolasduczek added the kind/feature new feature, enhancement, improvement, extension label Nov 4, 2024
@github-actions github-actions bot added the area/ipcei Important Project of Common European Interest label Nov 4, 2024
@morri-son morri-son added component/ocm-cli OCM Command Line Interface component/ocm-core Open Component Model Core aka. go API labels Nov 4, 2024
@morri-son morri-son added this to the 2024-Q4 milestone Nov 6, 2024
@morri-son
Copy link
Contributor

morri-son commented Nov 7, 2024

Hi @nicolasduczek, we tried to reproduce your issue with the following setup, but didn't run into issues. We used the standard OS env variables to configure an HTTP proxy. We set up a local OCI registry listening on port 5000 and a local http proxy listening on port 8080.

We used another alias for localhost in /etc/hosts, because go has a special handling for localhost with regards to proxies, then we did (with ls-registry being the alias for the OCI registry):

HTTP_PROXY=localhost:8080 HTTPS_PROXY=localhost:8080 ocm get component http://ls-registry:5000/ocm//ocm.software/ocmcli

and got a correct answer from the OCM CLI:

2024-11-07T12:59:36+01:00 warning [ocm/oci/ocireg] "using insecure http for oci registry ls-registry:5000"
COMPONENT           VERSION PROVIDER
ocm.software/ocmcli 0.7.0   ocm.software

Can you please ask the client to check if the same is possible at their side? If there run into any issues, please attach as much information about environment, usage and errors to this issue so that we can look into the problem again.

@hilmarf hilmarf mentioned this issue Nov 8, 2024
3 tasks
@hilmarf
Copy link
Member

hilmarf commented Nov 12, 2024

The folks say that an `ocm transfer cv my-registry/my-repo/my-component:0.8.15 /mnt/my-filesystem does not work in a Proxy env

@hilmarf hilmarf modified the milestones: 2024-Q4, 2025-Q1 Nov 21, 2024
@jakobmoellerdev
Copy link
Contributor

We did verify that most / if not all HTTP clients we create use HTTP_PROXY / HTTPS_PROXY and that transfers worked as well. we would need a concrete reproducer first. This issue is otherwise unacceptable

@morri-son morri-son moved this from 🆕 ToDo to 📋 Next-UP in OCM Backlog Board Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ipcei Important Project of Common European Interest component/ocm-cli OCM Command Line Interface component/ocm-core Open Component Model Core aka. go API kind/feature new feature, enhancement, improvement, extension
Projects
Status: 📋 Next-UP
Development

No branches or pull requests

4 participants