Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jfrog plugin + helm upload handler #1167

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jakobmoellerdev
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev commented Nov 29, 2024

What this PR does / why we need it

Implements a JFrog Plugin that contains an uploader that is able to upload to JFrog Helm Chart Repositories (different from OCI).

Example Reference Upload configuration:

- type: credentials.config.ocm.software
  consumers:
  - identity:
      type: JFrogHelm
      hostname: int.repositories.cloud.sap
    credentials:
    - type: Credentials/v1
      properties:
        username: "your-user-here"
        password: "your-token-here"
- type: uploader.ocm.config.ocm.software
  registrations:
  - name: plugin/jfrog/JFrogHelm
    artifactType: helmChart
    priority: 200
    config:
      type: JFrogHelm/v1alpha1
      url: "your-artifactory-url-here"
      repository: "your-repository-here"

Which issue(s) this PR fixes

fix #1116

@github-actions github-actions bot added kind/feature new feature, enhancement, improvement, extension size/l Large labels Nov 29, 2024
@github-actions github-actions bot added the component/github-actions Changes on GitHub Actions or within `.github/` directory label Dec 3, 2024
@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review December 11, 2024 16:52
@jakobmoellerdev jakobmoellerdev requested a review from a team as a code owner December 11, 2024 16:52
@Skarlso Skarlso self-assigned this Dec 16, 2024
Copy link
Contributor

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review before starting to play around with this.

api/ocm/plugin/cache/updater.go Show resolved Hide resolved
api/ocm/plugin/cache/updater.go Show resolved Hide resolved
api/ocm/plugin/plugin.go Show resolved Hide resolved
api/ocm/plugin/plugin.go Outdated Show resolved Hide resolved
api/ocm/plugin/ppi/cmds/upload/put/cmd.go Outdated Show resolved Hide resolved
cmds/jfrogplugin/uploaders/helm/helm.go Outdated Show resolved Hide resolved
cmds/jfrogplugin/uploaders/helm/helm.go Show resolved Hide resolved
cmds/jfrogplugin/uploaders/helm/helm.go Show resolved Hide resolved
cmds/jfrogplugin/uploaders/helm/helm.go Outdated Show resolved Hide resolved
cmds/jfrogplugin/uploaders/helm/upload.go Show resolved Hide resolved
Co-authored-by: Gergely Brautigam <182850+skarlso@users.noreply.github.com>
@hilmarf hilmarf added this to the 2024-Q4 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/github-actions Changes on GitHub Actions or within `.github/` directory kind/feature new feature, enhancement, improvement, extension size/l Large
Projects
Status: 🔍 Review
Development

Successfully merging this pull request may close these issues.

Create uploader handler for artifact type "helmChart" to Helm repositores
3 participants