Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop replacing cobra package with a user owned fork #53

Closed
Skarlso opened this issue Aug 11, 2022 · 14 comments · Fixed by #313
Closed

Stop replacing cobra package with a user owned fork #53

Skarlso opened this issue Aug 11, 2022 · 14 comments · Fixed by #313
Assignees
Labels

Comments

@Skarlso
Copy link
Contributor

Skarlso commented Aug 11, 2022

This replace statement in the go.mod file:

replace github.com/spf13/cobra => github.com/mandelsoft/cobra v1.4.1-0.20220807114430-d47656a53e96

...should be removed. The required feature should either be worked out differently or used differently.
This fork belongs to a user instead of the community behind cobra, which constantly updates the package and applies security fixes. This package is already 17 commits behind at the time of this writing, including a fix here which appears to have fixed the reason why the fork exists.

@Skarlso Skarlso added the kind/bugfix Bug label Aug 11, 2022
@mandelsoft
Copy link
Contributor

mandelsoft commented Aug 16, 2022

I've opened a PR spf13/cobra#1716 with the changes fro this repo. But nobody cares about that,

@Skarlso
Copy link
Contributor Author

Skarlso commented Aug 16, 2022

If we really want this feature, clone the repo under the gardener organisation and apply patches to it regularly.

@Skarlso
Copy link
Contributor Author

Skarlso commented Aug 16, 2022

But as I pointed out, I saw that there is something similar that has been applied. Is there a chance that that helps? Can we try using that feature?

@mandelsoft
Copy link
Contributor

I looked at the change you mentioned above. But this is something else.

@mandelsoft
Copy link
Contributor

I rebased the pr to the lasted main

@Skarlso
Copy link
Contributor Author

Skarlso commented Aug 16, 2022

Sure, so let's clone it under gardener, then we can pin to it. This will ensure that other maintainers of the org can include changes into the fork.

@In-Ko
Copy link
Member

In-Ko commented Aug 29, 2022

I believe we should do this after we have moved everything to the official new "open-component-model" org, right ? So let's park this until we have moved the other OCM-repos (#67 )

@yitsushi
Copy link
Contributor

yitsushi commented Nov 7, 2022

Any progress on this one?

@Skarlso
Copy link
Contributor Author

Skarlso commented Nov 7, 2022

Uwe added more context and information to his PR. It's awaiting Review. I pinged Marc.

@ikhandamirov
Copy link
Contributor

Hi @Skarlso, Marc is not very responsive in the recent months. Maybe for a good reason. Is there a different possibility to bring it to attention of VMware?

@Skarlso
Copy link
Contributor Author

Skarlso commented Feb 17, 2023

It's the contributors / maintainers of cobra that needs to be made aware and not VMware. :)

@ikhandamirov
Copy link
Contributor

@Skarlso you are right, of course. But the question remains, if there is somebody else to ping.

@Skarlso
Copy link
Contributor Author

Skarlso commented Feb 17, 2023

I don't know sadly. Look through the contributors and who is the most active one and ping them. 😊

@ikhandamirov
Copy link
Contributor

@Skarlso This is exactly the reply I was afraid of. :) I was hoping for personal connection of you, which could be magically activated. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants