-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop replacing cobra package with a user owned fork #53
Comments
I've opened a PR spf13/cobra#1716 with the changes fro this repo. But nobody cares about that, |
If we really want this feature, clone the repo under the gardener organisation and apply patches to it regularly. |
But as I pointed out, I saw that there is something similar that has been applied. Is there a chance that that helps? Can we try using that feature? |
I looked at the change you mentioned above. But this is something else. |
I rebased the pr to the lasted main |
Sure, so let's clone it under gardener, then we can pin to it. This will ensure that other maintainers of the org can include changes into the fork. |
I believe we should do this after we have moved everything to the official new "open-component-model" org, right ? So let's park this until we have moved the other OCM-repos (#67 ) |
Any progress on this one? |
Uwe added more context and information to his PR. It's awaiting Review. I pinged Marc. |
Hi @Skarlso, Marc is not very responsive in the recent months. Maybe for a good reason. Is there a different possibility to bring it to attention of VMware? |
It's the contributors / maintainers of cobra that needs to be made aware and not VMware. :) |
@Skarlso you are right, of course. But the question remains, if there is somebody else to ping. |
I don't know sadly. Look through the contributors and who is the most active one and ping them. 😊 |
@Skarlso This is exactly the reply I was afraid of. :) I was hoping for personal connection of you, which could be magically activated. :) |
This
replace
statement in thego.mod
file:...should be removed. The required feature should either be worked out differently or used differently.
This fork belongs to a user instead of the community behind cobra, which constantly updates the package and applies security fixes. This package is already 17 commits behind at the time of this writing, including a fix here which appears to have fixed the reason why the fork exists.
The text was updated successfully, but these errors were encountered: