From caa4a8480a8eb2afc484982217eb85f246a8ddc6 Mon Sep 17 00:00:00 2001
From: Jesse Vickery <jesse.vickery@tbs-sct.gc.ca>
Date: Thu, 10 Oct 2024 13:40:12 +0000
Subject: [PATCH] fix(pd): service-std filter;

- Catch for no `performance`.
---
 bin/filter/filter_service_std.py | 4 ++--
 changes/0009.bugfix              | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)
 create mode 100644 changes/0009.bugfix

diff --git a/bin/filter/filter_service_std.py b/bin/filter/filter_service_std.py
index 139d16083..f411800c2 100755
--- a/bin/filter/filter_service_std.py
+++ b/bin/filter/filter_service_std.py
@@ -52,8 +52,8 @@ def main():
         if row['target']:
             target = float(row['target'])
 
-            # if no total_volume then target_met is not possible
-            if den <= 0:
+            # if no performance(volume_meeting_target/total_volume) then target_met is not possible
+            if row['performance'] is None:
                 row['target_met'] = 'NA'
 
             # if performance >= target then target is met
diff --git a/changes/0009.bugfix b/changes/0009.bugfix
new file mode 100644
index 000000000..f37596b59
--- /dev/null
+++ b/changes/0009.bugfix
@@ -0,0 +1 @@
+Fixed an issue with the Standard Service filter script not handling null `performance` fields.