feat(flipt): able to provide additional gRPC Dial Options #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunturaf
changed the title
Signed-off-by: Guntur Akhmad Fauzi <guntur@stockbit.com>
Signed-off-by: Guntur Akhmad Fauzi <guntur@stockbit.com>
Signed-off-by: Guntur Akhmad Fauzi <guntur@stockbit.com>
Signed-off-by: Guntur Akhmad Fauzi <guntur@stockbit.com>
gunturaf
force-pushed
the
grpc-dial-options
branch
from
1be525a to
7c7a9ed
Compare
beeme1mr
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
grpc.WithDefaultServiceConfig(...), a Service Config allows devs to set quality-of-life things such as retry strategy.grpc.Dial()->grpc.NewClient()grpc.WithBlock()as it's deprecated, users can migrate to gRPC Service Config's waitForReady.fmt.Errorfwitherrors.Newas the error has no additional params so it won't benefit by usingfmt.Errorf.Related Issues
Notes
I don't know who to tag and sorry for tagging you, would you kindly help review my PR? @markphelps & Flipt core team.
Follow-up Tasks
How to test