feat: implement spec 0.7.0 changes #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* run any event handler immediately if the provider is in the associated state, not just ready * add prividerName to event details * add STALE provider state * update/add associated tests * also fixed spec/test associations mismatches from previous changes Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Codecov Report
@@ Coverage Diff @@
## main #655 +/- ##
============================================
+ Coverage 94.54% 94.71% +0.16%
- Complexity 357 363 +6
============================================
Files 32 32
Lines 843 851 +8
Branches 52 51 -1
============================================
+ Hits 797 806 +9
+ Misses 24 23 -1
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
toddbaert
requested review from
justinabrahms,
beeme1mr,
thiyagu06,
thomaspoignant,
liran2000 and
DBlanchard88
Kavindu-Dodan
approved these changes
Oct 16, 2023
beeme1mr
approved these changes
Oct 16, 2023
toddbaert
commented
Oct 16, 2023
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
thiyagu06
reviewed
Oct 18, 2023
Co-authored-by: Thiyagu GK <thiyagu103@gmail.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
force-pushed
the
feat/0.7.0
branch
3 times, most recently
from
7786121
to
217e733
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
|
Let's try and merge this tomorrow unless someone identifies a blocker. |
|
@thiyagu06 I've accepted the change you proposed. Can you re-review? |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #599