chore: split controllers to separate packages + cover them with unit tests

[odubajDT]

This PR

• moves controllers to separate packages
• moves common functions/constants into separate common package
• migrates ginkgo controller tests to basic unit tests

Related Issues

Fixes #393

[codecov]

Codecov Report

Merging #404 (155c5bb) into main (6133060) will increase coverage by 7.03%.
The diff coverage is 68.88%.

@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
+ Coverage   71.09%   78.12%   +7.03%     
==========================================
  Files          11       12       +1     
  Lines         851      855       +4     
==========================================
+ Hits          605      668      +63     
+ Misses        217      153      -64     
- Partials       29       34       +5     

Impacted Files	Coverage Δ
...ollers/core/featureflagconfiguration/controller.go	54.63% <35.29%> (ø)
...rollers/core/flagsourceconfiguration/controller.go	45.16% <62.50%> (ø)
controllers/common/common.go	100.00% <100.00%> (ø)

Flag	Coverage Δ
component-tests	80.28% <ø> (+15.48%)	⬆️
unit-tests	36.25% <68.88%> (+11.69%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[AlexsJones]

Can you tell us why this is a good idea perhaps? I've not touched this code in a few months and the delta seems large.

[odubajDT]

Can you tell us why this is a good idea perhaps? I've not touched this code in a few months and the delta seems large.

Hello,
n general, packages should be kept as small as possible to make them easy to understand. Therefore we decided to split the controllers package and put each controller to a separate one.

Also this PR converting tests from ginkgo test framework to standard unit-test approach, so it's less flaky, as we experienced some problems with this approach in the past. Additionally more unit tests were added for api/controllers to increase the code coverage.

[odubajDT]

This PR is going to be split into 2 due to the size

[odubajDT]

Split of the PR completed, the follow-up PR with additional refactoring and unit tests will follow up

1. Follow up PR: chore: refactor admission webhook tests #409

Another PR regarding adding unit tests for api packages will come after this will get merged

[skyerus]

I like the splitting of the controllers package, nice

[odubajDT]

I like the splitting of the controllers package, nice

Thank you!

[toddbaert]

I'll give this a thorough review tomorrow!

[odubajDT]

I'll give this a thorough review tomorrow!

Thank you!

[toddbaert]

Approved with some minor comments, questions.