Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor admission webhook tests #409

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

odubajDT
Copy link
Contributor

This PR

  • migrate webhook ginkgo tests to standard unit tests
  • minor refactoring of admission webhook

Copy link
Contributor

@skyerus skyerus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table tests ftw :)

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #409 (7d0bfa4) into main (3212eba) will decrease coverage by 1.64%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
- Coverage   72.72%   71.09%   -1.64%     
==========================================
  Files          11       11              
  Lines         847      851       +4     
==========================================
- Hits          616      605      -11     
- Misses        205      217      +12     
- Partials       26       29       +3     
Impacted Files Coverage Δ
webhooks/featureflagconfiguration_webhook.go 81.25% <86.36%> (-5.12%) ⬇️

... and 1 file with indirect coverage changes

Flag Coverage Δ
component-tests 64.80% <86.36%> (-2.07%) ⬇️
unit-tests 24.55% <86.36%> (+3.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@beeme1mr beeme1mr merged commit 29c7c28 into open-feature:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants