-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate flagd startup argument to sources flag #427
feat: migrate flagd startup argument to sources flag #427
Conversation
Codecov Report
@@ Coverage Diff @@
## main #427 +/- ##
==========================================
+ Coverage 77.76% 79.13% +1.36%
==========================================
Files 21 21
Lines 1300 1323 +23
==========================================
+ Hits 1011 1047 +36
+ Misses 248 234 -14
- Partials 41 42 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
5d9432c
to
67da614
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few small comments, but LGTM
d146e07
to
c5f9276
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for circling back to this after the related flagd changes. I tried to find something to be improved but I can't 😅 . LGTM.
Thank you :) |
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
df0f029
to
06eb625
Compare
Prerequisite
Release of flagd 0.4.6
This PR
Fixes #389
This PR migrate flagd side-car startup arguments from
uri
(flagd start --uri <sync-source>
) tosources
(flagd start --sources <sync-source>
).More on the new
sources
based configuration options [1]With this option, I have introduced the grpc sync option to OFO and other grpc sync-provider options.
follow-up
Discussion - type
SourceConfig
can be referred from OFO dependency and avoid duplication at flagd[1] - https://github.com/open-feature/flagd/blob/main/docs/configuration/configuration.md