Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactored component test using fake client #435

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Mar 31, 2023

This PR

  • substitute the ginkgo component tests for the webhook with fake client ones

@RealAnna RealAnna requested a review from a team as a code owner March 31, 2023 11:41
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #435 (14d2d5e) into main (0e779e8) will decrease coverage by 1.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
- Coverage   79.13%   78.00%   -1.14%     
==========================================
  Files          21       21              
  Lines        1323     1323              
==========================================
- Hits         1047     1032      -15     
- Misses        234      251      +17     
+ Partials       42       40       -2     

see 3 files with indirect coverage changes

Flag Coverage Δ
component-tests ?
unit-tests 78.00% <ø> (+16.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice work! :)

…ditions

Signed-off-by: realanna <anna.reale@dynatrace.com>

refactor: fixed silly unit test

Signed-off-by: realanna <anna.reale@dynatrace.com>

refactor: remove redundant component test pipeline

Signed-off-by: realanna <anna.reale@dynatrace.com>

refactor: rewrote component tests using fake client to avoid race conditions

Signed-off-by: realanna <anna.reale@dynatrace.com>

chore: converted ginko tests

Signed-off-by: realanna <anna.reale@dynatrace.com>

chore: converted ginko tests

Signed-off-by: realanna <anna.reale@dynatrace.com>

chore: added a test

Signed-off-by: realanna <anna.reale@dynatrace.com>

chore: added a test

Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
@toddbaert toddbaert self-requested a review April 3, 2023 12:28
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woohoo! this is great! A whole job gone from CI. Thanks a lot for this @RealAnna . I guess these are much faster too with the fake.client.

I looked through all the changes, and nothing seemed out of order.

@toddbaert toddbaert merged commit 08a50ac into open-feature:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants