Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] update tutorials to properly wait ready #299

Closed
toddbaert opened this issue Dec 14, 2023 · 1 comment · Fixed by #470
Closed

[BUG] update tutorials to properly wait ready #299

toddbaert opened this issue Dec 14, 2023 · 1 comment · Fixed by #470
Assignees
@jonathannorris
Labels
contribfest A good issue for Contribfest KubeCon EU '24 documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@toddbaert
Copy link
Member

toddbaert commented Dec 14, 2023 •
edited
Loading

The getting started tutorials do not properly await provider readiness. All tutorials should be updated to either wait for a READY event, or use a blocking provider mutator (ie: OpenFeature.setProviderAndWait(provider).

Relates to: open-feature/go-sdk#238
@toddbaert toddbaert added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Dec 14, 2023
@toddbaert toddbaert added the contribfest A good issue for Contribfest KubeCon EU '24 label Mar 11, 2024
@jonathannorris
Copy link
Member

tackling this change.

@jonathannorris jonathannorris mentioned this issue Mar 22, 2024
Merged
@jonathannorris jonathannorris mentioned this issue Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathannorris jonathannorris

Labels
contribfest A good issue for Contribfest KubeCon EU '24 documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: go tutorial to use SetProviderAndWait() DevCycleHQ-Sandbox/openfeature.dev
2 participants
@jonathannorris @toddbaert