Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[goalc] Typing an umlaut instantly crashes goalc #1130

Closed
Hat-Kid opened this issue Feb 4, 2022 · 4 comments
Closed

[goalc] Typing an umlaut instantly crashes goalc #1130

Hat-Kid opened this issue Feb 4, 2022 · 4 comments
Labels
compiler Compiler Related

Comments

@Hat-Kid
Copy link
Member

Hat-Kid commented Feb 4, 2022

Typing an umlaut (ä, ö or ü) instantly crashes the REPL.

goalc: /home/philip/code/git/jak-project/./common/util/Trie.h:45: static int Trie<T>::idx(char) [with T = std::vector<SymbolInfo>]: Assertion `c >= CHAR_START' failed.
[1]    820678 abort (core dumped)  ./build/goalc/goalc
@ManDude
Copy link
Member

ManDude commented Feb 4, 2022

Pretty much any fancy character will do this it seems.

@water111
Copy link
Collaborator

water111 commented Feb 6, 2022

It looks like this problem is just with the auto-complete stuff. I fixed the prefix tree (the part that was crashing) in #1138 but there's still something weird going on with the REPL library or the way we've implemented autocomplete. the character just disappears now, which is annoying, but better than just crashing.

@xTVaser xTVaser added the compiler Compiler Related label Feb 12, 2022
@xTVaser
Copy link
Member

xTVaser commented Feb 12, 2022

I can't reproduce this on windows, it looks like our exceptions are not converting to utf-16, but characters don't disappear upon entry (or when pressing tab to complete)
image

Maybe this is linux specific?

@water111
Copy link
Collaborator

water111 commented Jun 2, 2022

looks like this no longer crashes.

@water111 water111 closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Compiler Related
Projects
None yet
Development

No branches or pull requests

4 participants