Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eye] filtering #1206

Closed
ManDude opened this issue Feb 26, 2022 · 3 comments · Fixed by #1214
Closed

[eye] filtering #1206

ManDude opened this issue Feb 26, 2022 · 3 comments · Fixed by #1214

Comments

@ManDude
Copy link
Member

ManDude commented Feb 26, 2022

image

I'm not sure our texture filtering for the eyes is totally correct (well actually it doesn't look like there's any filtering at all). Sometimes it looks kinda weird. We can probably just apply some quick linear filtering.
image
@water111 water111 mentioned this issue Mar 3, 2022
Merged
@water111 water111 reopened this Mar 3, 2022
@water111
Copy link
Collaborator

water111 commented Mar 3, 2022

emulator filtering on pupil (ours isn't as round)
image

bird lady off-by-one (emulator doesn't have the little gap) maybe we should check the software renderer because pcsx2 is also off sometimes.
image

@ManDude
Copy link
Member Author

ManDude commented Mar 3, 2022

software mode looks fine:
image

@water111
Copy link
Collaborator

water111 commented Mar 4, 2022

both fixed in #1219

@water111 water111 closed this as completed Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[eyes] enable filter by default and fix up bucket hacks open-goal/jak-project
2 participants
@ManDude @water111