Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Decompiler] If the out_folder does not already exist, exceptions are raised #234

Closed
xTVaser opened this issue Feb 5, 2021 · 1 comment
Closed

[Decompiler] If the out_folder does not already exist, exceptions are raised #234

xTVaser opened this issue Feb 5, 2021 · 1 comment

Comments

@xTVaser
Copy link
Member

xTVaser commented Feb 5, 2021

If the folder designated for dumping the decompilation doesn't already exist before running the decompilation, exceptions occur. There seems to be checks that seem to be too late in the process that could be moved earlier on.

https://github.com/water111/jak-project/blob/2436a8a5410aa46311579ccd81166e03a526df85/decompiler/main.cpp#L51-L55
@xTVaser
Copy link
Member Author

xTVaser commented Feb 8, 2021

fixed in #242

@xTVaser xTVaser closed this as completed Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xTVaser