Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decompiler: Creating an invalid JSON config file doesn't have an actionable error #462

Closed
xTVaser opened this issue May 12, 2021 · 2 comments

Comments

@xTVaser
Copy link
Member

xTVaser commented May 12, 2021

When editing one of the several JSON files and you make a mistake, the decompiler will just hit an assertion failure. It would be better if it also logged the err from nholmann which i assume atleast references a line number.

@water111
Copy link
Collaborator

I have been getting at least some info on Linux, but its through an uncaught exception and maybe windows doesn't print this?

Either way, I added something in #463 to print an actual error like this:

[2021-05-11 21:37:24:733] [error] Error parsing JSON in file decompiler/config/jak1_ntsc_black_label/label_types.jsonc: [json.exception.parse_error.101] parse error at line 267, column 5: syntax error while parsing object key - unexpected '['; expected string literal

@xTVaser
Copy link
Member Author

xTVaser commented May 13, 2021

Yup, a lot better now!

[2021-05-12 20:09:02] [error] Error parsing JSON in file decompiler/config/jak1_ntsc_black_label/label_types.jsonc: [json.exception.parse_error.101] parse error at line 356, column 5: syntax error while parsing array - unexpected '['; expected ']'
task: Failed to run task "decomp-file": task: Failed to run task "decomp": exit status 3

@xTVaser xTVaser closed this as completed May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants