-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix ] MMDetWandbHook does not support offline mode #8755
Conversation
Codecov ReportBase: 64.08% // Head: 64.06% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #8755 +/- ##
==========================================
- Coverage 64.08% 64.06% -0.03%
==========================================
Files 361 361
Lines 29525 29527 +2
Branches 5020 5021 +1
==========================================
- Hits 18922 18916 -6
- Misses 9589 9593 +4
- Partials 1014 1018 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hey @i-aki-y, just curious to know if you are using W&B Tables when using |
@ayulockin Hi, Thank you for your review. No, I do not use W&B Tables intentionally in offline mode.
|
Awesome, makes sense. Thanks for clarifying. |
Dear i-aki-y, |
Motivation
I got the following error when I used
MMDetWandbHook
in the offline mode:The log_config is the following:
Modification
I think the
use_artifact
andwait
methods in the following codes can be skipped when the wandb is offline:mmdetection/mmdet/core/hook/wandblogger_hook.py
Lines 559 to 573 in df28da9
BC-breaking (Optional)
When the wandb is in the online mode (it is the default mode), there is no change.
Use cases (Optional)
I use the offline mode when I debug and test the codes.
Checklist
About unit test:
To test the MMDetwandbHook, we need a full training setup (prepare dataset and install wandb and login), but I am not sure how to write this type of test efficiently.
I would appreciate any advice about this.