Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove alpha flags from values and add conditional checks before setting flags through helm #3483

Open
JaydipGabani opened this issue Aug 9, 2024 · 0 comments · May be fixed by #3578
Open

Remove alpha flags from values and add conditional checks before setting flags through helm #3483

JaydipGabani opened this issue Aug 9, 2024 · 0 comments · May be fixed by #3578
Assignees
@JaydipGabani
Milestone
v3.18.0

Comments

@JaydipGabani
Copy link
Contributor

To avoid setting alpha flags through helm during upgrades or install accidently, we should remove alpha flags from values.yaml and add a check to set the flag only when the variable is passed through values.

For reference #3481
@JaydipGabani JaydipGabani self-assigned this Aug 9, 2024
@ritazh ritazh added this to the v3.18.0 milestone Aug 14, 2024
@JaydipGabani JaydipGabani linked a pull request Oct 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaydipGabani JaydipGabani

Labels
None yet
Projects
None yet
Milestone
v3.18.0
Development

Successfully merging a pull request may close this issue.

chore: remove setting alpha flags out of box JaydipGabani/gatekeeper
2 participants
@ritazh @JaydipGabani