From af8f915846fa325fe009dd6c226122bb205cff0a Mon Sep 17 00:00:00 2001
From: Anders Eknert <anders@eknert.com>
Date: Thu, 26 Sep 2024 22:21:14 +0200
Subject: [PATCH] Add `mirror` linter

This flags unnecessary conversions of byte->string and vice versa

Signed-off-by: Anders Eknert <anders@eknert.com>
---
 .golangci.yaml                 | 1 +
 cmd/exec_test.go               | 2 +-
 cmd/internal/exec/exec_test.go | 2 +-
 compile/compile_test.go        | 2 +-
 topdown/http.go                | 2 +-
 5 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/.golangci.yaml b/.golangci.yaml
index 5ac97ced90..fa4be358c0 100644
--- a/.golangci.yaml
+++ b/.golangci.yaml
@@ -11,6 +11,7 @@ linter-settings:
 linters:
   disable-all: true
   enable:
+    - mirror
     - errcheck
     - govet
     - ineffassign
diff --git a/cmd/exec_test.go b/cmd/exec_test.go
index 635d22dffc..25f7b46e27 100644
--- a/cmd/exec_test.go
+++ b/cmd/exec_test.go
@@ -1191,7 +1191,7 @@ func TestExecWithInvalidInputOptions(t *testing.T) {
 					if err != nil {
 						t.Fatalf("unexpected error creating temp file: %q", err.Error())
 					}
-					if _, err := tempFile.Write([]byte(tt.input)); err != nil {
+					if _, err := tempFile.WriteString(tt.input); err != nil {
 						t.Fatalf("unexpeced error when writing to temp file: %q", err.Error())
 					}
 					if _, err := tempFile.Seek(0, 0); err != nil {
diff --git a/cmd/internal/exec/exec_test.go b/cmd/internal/exec/exec_test.go
index 2c2476c27f..c133970872 100644
--- a/cmd/internal/exec/exec_test.go
+++ b/cmd/internal/exec/exec_test.go
@@ -209,7 +209,7 @@ func TestExec(t *testing.T) {
 					if err != nil {
 						t.Fatalf("unexpected error creating temp file: %q", err.Error())
 					}
-					if _, err := tempFile.Write([]byte(tt.input)); err != nil {
+					if _, err := tempFile.WriteString(tt.input); err != nil {
 						t.Fatalf("unexpeced error when writing to temp file: %q", err.Error())
 					}
 					if _, err := tempFile.Seek(0, 0); err != nil {
diff --git a/compile/compile_test.go b/compile/compile_test.go
index be1790ba63..80016a1e14 100644
--- a/compile/compile_test.go
+++ b/compile/compile_test.go
@@ -1893,7 +1893,7 @@ func modulesToString(modules []bundle.ModuleFile) string {
 	for i, m := range modules {
 		buf.WriteString(strconv.Itoa(i))
 		buf.WriteString(":\n")
-		buf.WriteString(string(m.Raw))
+		buf.Write(m.Raw)
 		buf.WriteString("\n\n")
 	}
 	return buf.String()
diff --git a/topdown/http.go b/topdown/http.go
index a84faf0851..c2b916f01f 100644
--- a/topdown/http.go
+++ b/topdown/http.go
@@ -473,7 +473,7 @@ func createHTTPRequest(bctx BuiltinContext, obj ast.Object) (*http.Request, *htt
 			}
 			body = bytes.NewBuffer(bodyValBytes)
 		case "raw_body":
-			rawBody = bytes.NewBuffer([]byte(strVal))
+			rawBody = bytes.NewBufferString(strVal)
 		case "tls_use_system_certs":
 			tempTLSUseSystemCerts, err := strconv.ParseBool(obj.Get(val).String())
 			if err != nil {