Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support opa-envoy linux/arm64 Docker Image #4965

Closed
Nebu1eto opened this issue Aug 4, 2022 · 19 comments · Fixed by open-policy-agent/opa-envoy-plugin#577
Closed

Support opa-envoy linux/arm64 Docker Image #4965

Nebu1eto opened this issue Aug 4, 2022 · 19 comments · Fixed by open-policy-agent/opa-envoy-plugin#577

Comments

@Nebu1eto
Copy link

Nebu1eto commented Aug 4, 2022

What is the underlying problem you're trying to solve?

I'm using opa-envoy, but it doesn't support linux/arm64 architecture. So I can't use this on Graviton 2 (AWS).

Describe the ideal solution

If there are no problem to build opa-envoy image for arm64, can you please support this? If not, It is issue and it have to be resolved.

@srenatus
Copy link
Contributor

There's no technical reason not to do it; it's just work that needs to be done. Would you be interested in adding the steps done with OPA in db4d987 with opa-envoy-plugin...?

@stale
Copy link

stale bot commented Sep 14, 2022

This issue has been automatically marked as inactive because it has not had any activity in the last 30 days.

@stale stale bot added the inactive label Sep 14, 2022
@sidharthramesh
Copy link

can we please have this?

@stale stale bot removed the inactive label Oct 25, 2022
@srenatus
Copy link
Contributor

Contributions welcome! Happy to assist.

The setup here could also be simpler than what OPA does: since no cgo is needed, we could use ko.

@sidharthramesh
Copy link

Thank you @srenatus. I'll get started on this. CC: @Areefks

@sidharthramesh
Copy link

sidharthramesh commented Nov 12, 2022

@srenatus Ko seems to do all of the heavy lifting of multiarch image builds. Should I replace all of these lines with Ko's CLI instead of docker build?

https://github.com/open-policy-agent/opa-envoy-plugin/blob/c37ea9d489b8f8144d449abbe294a1d6cde7ffa2/Makefile#L86-L111

@sidharthramesh
Copy link

@srenatus Do we need the whole replacing the Dockerfile arch business when we switch to Ko?

sed -e 's/GOARCH/$(GOARCH)/g' Dockerfile > .Dockerfile_$(GOARCH)

@sidharthramesh
Copy link

Where exactly is the docker build happening?

https://github.com/open-policy-agent/opa-envoy-plugin/blob/c37ea9d489b8f8144d449abbe294a1d6cde7ffa2/.github/workflows/post-tag.yaml#L23 this doesn't seem to be building the images, only the binaries?

@srenatus
Copy link
Contributor

@stale
Copy link

stale bot commented Dec 12, 2022

This issue has been automatically marked as inactive because it has not had any activity in the last 30 days.

@3goats
Copy link

3goats commented Apr 3, 2024

+1

@stale stale bot removed the inactive label Apr 3, 2024
Copy link

stale bot commented May 3, 2024

This issue has been automatically marked as inactive because it has not had any activity in the last 30 days. Although currently inactive, the issue could still be considered and actively worked on in the future. More details about the use-case this issue attempts to address, the value provided by completing it or possible solutions to resolve it would help to prioritize the issue.

@stale stale bot added the inactive label May 3, 2024
@leofernandezg
Copy link

+1

@stale stale bot removed the inactive label Jun 7, 2024
@kenissongmelo
Copy link

+1

1 similar comment
@leandrosantoro
Copy link

+1

@tjons
Copy link
Contributor

tjons commented Jun 7, 2024

@srenatus I'll work on this one!

Copy link

stale bot commented Jul 8, 2024

This issue has been automatically marked as inactive because it has not had any activity in the last 30 days. Although currently inactive, the issue could still be considered and actively worked on in the future. More details about the use-case this issue attempts to address, the value provided by completing it or possible solutions to resolve it would help to prioritize the issue.

@tjons
Copy link
Contributor

tjons commented Aug 4, 2024

open-policy-agent/opa-envoy-plugin#577 should resolve this!

@srenatus
Copy link
Contributor

🥳 yaaaay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants