Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

Add contributors table #25

Merged
merged 3 commits into from
Mar 18, 2022
Merged

Conversation

Shreyanand
Copy link
Member

For issue #22, this PR fetches events from repositories, extracts contributor information from them and adds a table to Trino for visualization.
Also, it updates the pipfile with required dependencies.

Co-authored-by: Hema Veeradhi hveeradh@redhat.com
Co-authored-by: Karanraj Chauhan kachau@redhat.com

Karanraj Chauhan and others added 2 commits February 22, 2022 20:42
Co-authored-by: Shrey Anand <shanand@redhat.com>
Co-authored-by: Hema Veeradhi <hveeradh@redhat.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sesheta sesheta added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 10, 2022
@suppathak
Copy link
Member

/lgtm 👍

@suppathak
Copy link
Member

/test pre-commit

Copy link
Member

@oindrillac oindrillac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2022
@hemajv
Copy link
Member

hemajv commented Mar 14, 2022

@Shreyanand any reason for pre-commit failing?

@Shreyanand
Copy link
Member Author

Seems like this module is not available to the pre-commit environment (source).
@harshad16 any idea why that's happening?

@harshad16
Copy link

/retest

@harshad16
Copy link

Seems like this module is not available to the pre-commit environment (source).

@Shreyanand seems like the module not available issue is already fixed:
s-weigand/flake8-nb#206

@hemajv hemajv requested a review from MichaelClifford March 15, 2022 18:35
@Shreyanand
Copy link
Member Author

Shreyanand commented Mar 15, 2022

@harshad16 thanks, it seems it's fixed but I tried to pre-commit clean and then initialize the environment again and saw another error:
Screenshot from 2022-03-15 15-23-48
Is this known?

@harshad16
Copy link

@Shreyanand please check all ssh url to htps URL

- repo: git://github.com/Lucas-C/pre-commit-hooks

to fix that authentication issue.

Co-authored-by: Hema Veeradhi <hveeradh@redhat.com>
Co-authored-by: Karanraj Chauhan <kachau@redhat.com>
@sesheta sesheta removed the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2022
@sesheta
Copy link
Contributor

sesheta commented Mar 15, 2022

New changes are detected. LGTM label has been removed.

@Shreyanand
Copy link
Member Author

Shreyanand commented Mar 15, 2022

@Shreyanand please check all ssh url to htps URL

- repo: git://github.com/Lucas-C/pre-commit-hooks

to fix that authentication issue.

Thanks, that fixed it 👍
Does this mean other repos .pre-commit-config.yaml has to change as well?

@harshad16
Copy link

@Shreyanand
yes, I had sent a note on this long ago.
here is the issue: thoth-station/thoth-application#2111
update your repo based on your convenience.

@Shreyanand
Copy link
Member Author

@Shreyanand yes, I had sent a note on this long ago. here is the issue: thoth-station/thoth-application#2111 update your repo based on your convenience.

Thanks this is helpful, added an issue in the project template for future projects using it.

@MichaelClifford
Copy link
Member

/approve

@sesheta
Copy link
Contributor

sesheta commented Mar 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MichaelClifford, oindrillac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
@sesheta sesheta merged commit f26ca3a into open-services-group:main Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants