Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting no longer works on macOS #58

Open
zepfietje opened this issue Feb 22, 2024 · 16 comments
Open

Formatting no longer works on macOS #58

zepfietje opened this issue Feb 22, 2024 · 16 comments
Labels
bug Something isn't working

Comments

@zepfietje
Copy link
Contributor

zepfietje commented Feb 22, 2024

Describe the bug

When using "Format document using Laravel Pint", "Format Document", or "Format On Save", PHP files are no longer formatted using the extension. Running ./vendor/bin/pint manually works just fine. I noticed this issue in the last couple weeks. Managed to fix it briefly by uninstall and reinstall the extension (IIRC), but it's back to broken again.

To Reproduce

Steps to reproduce the behavior:

  1. Install the extension.
  2. Open a poorly formatted PHP file in a Laravel project.
  3. Call "Formaat document using Laravel Pint" from the VS Code command palette.
  4. Watch as nothing happens.

Expected behavior

I expect the extension to format the file using Laravel Pint.

Screenshots

Environment:

  • Operating system: macOS
  • IDE / version: VSCode 1.86.2
  • Extension version: 1.1.8
  • Extension's config: "laravel-pint.enable": true,

Additional context

@zepfietje zepfietje added the bug Something isn't working label Feb 22, 2024
@d8vjork
Copy link
Member

d8vjork commented Feb 22, 2024

Weird, to me all these format methods works and I'm on a Mac using 1.1.8

@d8vjork
Copy link
Member

d8vjork commented Feb 22, 2024

Do you use any pint.json config? And what about the pint binary (global or local)? Any modification to the extension config?

@zepfietje
Copy link
Contributor Author

I don't use a pint.json config, have Pint configured on a per-project basis (so as dependency in composer.json). No modifications to extension.

@samlinck
Copy link

I have the same problem. Everything works fine when using vendor/bin/pint. But Format document using Laravel Pint does nothing.

@d8vjork
Copy link
Member

d8vjork commented Mar 21, 2024

I tried to replicate but still no luck, will probably do on a new install

pint_command_working.mp4

@Ukesh2010
Copy link

Having the same issue.

@hooch
Copy link

hooch commented Mar 30, 2024

Same issue, running vendor/bin/pint formats code as expected. But formatting from within VSC, nothing happens. This was with 1.2.0. Tried installing earlier versions but VSC reports CorruptZip: end of central directory record signature not found

@jleonardolemos
Copy link

Same for me using linux. Nothing happens in developer tools too.

@danielgalanrodriguez
Copy link

danielgalanrodriguez commented Apr 14, 2024

Same issue here. Nothing happens when formatting the document using Laravel Pint from VSC command palette.
I use the project's pint.json config with a local installation of the binary.

There is nothing strange in the output. Just the common message Formatting completed in XXms

Environment:

  • IDE / version: VSCode 1.88.1
  • Extension version: 1.2.0

For now I manage to get it working by:

  • Reinstalling the extension (Uninstall-Install)
  • Deleting and adding back the VSC config in the json file settings.json

Let's see if it happens again.

@gregoryalary
Copy link

Same issue as well :/

@SilvioLucasDev
Copy link

Same issue here

@zepfietje
Copy link
Contributor Author

zepfietje commented Jul 9, 2024

@d8vjork, have you been able to reproduce this issue yet?
It seems like a lot of other people are running into the same bug.

@yondifon
Copy link

same issue here.

@martin-ro
Copy link

Same here

@mangaljptech
Copy link

same here

@Adrug
Copy link

Adrug commented Nov 3, 2024

hm, I thought I was a lucky guy and couldn't make it work, but it looks like I have the same issue.
Any idea why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests