Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting up global attributes for all signals #256

Closed
LikeTheSalad opened this issue Feb 22, 2024 · 1 comment
Closed

Allow setting up global attributes for all signals #256

LikeTheSalad opened this issue Feb 22, 2024 · 1 comment

Comments

@LikeTheSalad
Copy link
Contributor

The current global attributes appender is targeted to Spans only (most likely due to historical reasons), this can cause issues such as some signals not having key dynamic attributes such as the session id for example, as mentioned in this comment.

Because of the above, we need to come up with a way to provide global attributes not only to all Spans but also to Metrics and Logs.

@LikeTheSalad
Copy link
Contributor Author

This has been done for logs already and I don't think we'll need it for metrics. So closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant