[exporter/clickhouse] Add instrumentation scope to span attribute

[huynhtehoa]

Component(s)

exporter/clickhouse

Is your feature request related to a problem? Please describe.

Currently, attributes such as otel.library.name, otel.library.version are not added to span attributes. Those attributes are parts of InstrumentationScope, which is provided by opentelemetry https://opentelemetry.io/docs/reference/specification/logs/data-model/#field-instrumentationscope

Describe the solution you'd like

It would be nice to include otel.library.name and otel.library.version in span attributes

Describe alternatives you've considered

No response

Additional context

No response

[huynhtehoa]

/label exporter/clickhouse

[github-actions]

Pinging code owners for exporter/clickhouse: @hanjm @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[hanjm]

looks good. I think store it to resource attribute is reasonable.

[Frapschen]

Is there some scenes need to do that? in jaeger, those attribute are include in UI:

[huynhtehoa]

Hi @Frapschen, we are storing traces in Clickhouse to build our custom monitoring dashboards and this library info will help us filter data better. For example, we can find out the slowest libraries, the most frequently used libraries

[Frapschen]

got it,I agree with @hanjm, I will add this to my work list. I notice that the clickhouse log exporter also have same issue, I will create new issue and fix it.

[huynhtehoa]

Thank you guys ❤️

[dmitryax]

@huynhtehoa @Frapschen Please see the spec translation guidelines https://github.com/open-telemetry/opentelemetry-specification/blob/7116e72cff72a825bbb83e103c2756706d3106ee/specification/common/mapping-to-non-otlp.md#instrumentationscope . They should be mapped to otel.scope.name and otel.scope.version

[Frapschen]

got it