Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal/comparetest] Add support for all metric types #17538

Closed
Tracked by #17544
dmitryax opened this issue Jan 12, 2023 · 5 comments · Fixed by #17579
Closed
Tracked by #17544

[internal/comparetest] Add support for all metric types #17538

dmitryax opened this issue Jan 12, 2023 · 5 comments · Fixed by #17579
Assignees
@fatsheep9146
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed internal/comparetest needs triage New item requiring triage priority:p2 Medium

Comments

@dmitryax
Copy link
Member

dmitryax commented Jan 12, 2023 •
edited
Loading

Currently, comparetest.CompareMetrics only support Sum and Gauge metric types. It should support all metric types including Histogram, ExponentialHistogram, and Summary.
@dmitryax dmitryax added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers priority:p2 Medium needs triage New item requiring triage internal/comparetest labels Jan 12, 2023
@dmitryax
Copy link
Member Author

@fatsheep9146 please let us know if you can work on this, given that you added support for traces.

@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

Pinging code owners for internal/comparetest: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@fatsheep9146
Copy link
Contributor

@fatsheep9146 please let us know if you can work on this, given that you added support for traces.

Of course! I will support this. @dmitryax

@fatsheep9146 fatsheep9146 self-assigned this Jan 12, 2023
@fatsheep9146 fatsheep9146 mentioned this issue Jan 12, 2023
Closed
9 tasks
@dmitryax dmitryax mentioned this issue Jan 15, 2023
Merged
@dmitryax
Copy link
Member Author

@fatsheep9146 I submitted a PR because I need this feature for other work. PTAL #17579.

Support of exemplars are still to be added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fatsheep9146 fatsheep9146

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed internal/comparetest needs triage New item requiring triage priority:p2 Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[internal/comparetest] Add support for all metric types dmitryax/opentelemetry-collector-contrib
2 participants
@dmitryax @fatsheep9146