[connectors/spanmetrics] Rename the operation attribute to span.name

[kovrus]

Component(s)

connector/spanmetrics

Describe the issue you're reporting

It should bring data point attributes produced by the spanmetrics connector closer to the specification, see Span spec.

It is the change that will be done in the new (not yet enabled) component, so it does not break anything for the existing users. However, we have to inform users about these changes when migrating from spanmeterics processor to spanmeterics connector.

[github-actions]

Pinging code owners:

• processor/spanmetrics: @albertteoh

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[albertteoh]

I think it's good, in principal, to bring this dimension name closer to the specification; so I have no objections.

Note that if we agree to rename operation to span.name, it will be a breaking change, which will also impact Jaeger SPM.

[kovrus]

@albertteoh Maybe we can do this change in the new component spanmetrics connector component and mark operation as deprecated in the spanmetrics processor component? Also, we can drop _total from the metric name in the spanmetrics connector. So we won't do any breaking changes in the processor now and will give users some time to migrate to the new spanmetrics connector that has these breaking changes. WDYT?

[Frapschen]

I recommend the metric name in the new 'spanmetric' can follow Prometheus's best practices. Giving a prefix to the metric name and keeping the _total.

[kovrus]

I recommend the metric name in the new 'spanmetric' can follow Prometheus's best practices. Giving a prefix to the metric name and keeping the _total.

The new spanmetric connector is the OTel component (not Prometheus specific component), by keeping _total as the metrics name we mix OTel data model and its naming convention with Prometheus conventions. I think, Prometheus's best practices have to be respected when generated metrics will be exported, e.g. with prometheusremovewrite and prometheus exporters (and that is already implemented). If generated metrics are exported with some other vendor or not vendor-specific component they should respect probably some other practices.

See also discussion here.

[albertteoh]

@albertteoh Maybe we can do this change in the new component spanmetrics connector component and mark operation as deprecated in the spanmetrics processor component? Also, we can drop _total from the metric name in the spanmetrics connector. So we won't do any breaking changes in the processor now and will give users some time to migrate to the new spanmetrics connector that has these breaking changes. WDYT?

Great suggestion, and good timing with the new spanmetrics being recently merged! 👍🏼

[Cluas]

The current spanmetrics connector implementation is just a port, can we add a config like standardized, Cluas@4530423

[github-actions]

Pinging code owners for connector/spanmetrics: @albertteoh. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[djaglowski]

Closed by #18746