-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[connectors/spanmetrics] Rename the operation
attribute to span.name
#18529
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I think it's good, in principal, to bring this dimension name closer to the specification; so I have no objections. Note that if we agree to rename |
@albertteoh Maybe we can do this change in the new component |
I recommend the metric name in the new 'spanmetric' can follow Prometheus's best practices. Giving a prefix to the metric name and keeping the |
The new See also discussion here. |
Great suggestion, and good timing with the new |
The current |
Pinging code owners for connector/spanmetrics: @albertteoh. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
operation
attribute to span.name
operation
attribute to span.name
Closed by #18746 |
operation
attribute to span.name
operation
attribute to span.name
Component(s)
connector/spanmetrics
Describe the issue you're reporting
It should bring data point attributes produced by the
spanmetrics
connector closer to the specification, see Span spec.It is the change that will be done in the new (not yet enabled) component, so it does not break anything for the existing users. However, we have to inform users about these changes when migrating from spanmeterics processor to spanmeterics connector.
The text was updated successfully, but these errors were encountered: