Prepare release script sed usage is still fragile #23981
Labels
admin issues
tracker issues etc.
ci-cd
CI, CD, testing, build issues
never stale
Issues marked with this label will be never staled and automatically removed
priority:p3
Lowest
release-retro
Issues discussed in a release retrospective
Component(s)
No response
Describe the issue you're reporting
For releases we use the "Automation - Prepare Release" workflow, which uses this script to create a PR that is the first step of the contrib release.
It used to look like
opentelemetry-collector-contrib/.github/workflows/scripts/release-prepare-release.sh
Lines 33 to 34 in fbd85e0
and after #23977 it looks like
opentelemetry-collector-contrib/.github/workflows/scripts/release-prepare-release.sh
Lines 33 to 36 in 401c353
This
sed
command may replace versions from dependencies we are replacing, which was the motivation for #23977. The current version still has some issues:.
on a version like0.80.0
are still interpreted as 'any character' bysed
, which is not what we want. A way to solve this is to do${CURRENT_BETA//\./\\.}
to escape dots as pointed out by @astencel-sumoWe should rework how we handle this replacement to avoid issues in the future.
The text was updated successfully, but these errors were encountered: