Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awsxray exporter requires OTLP trace id to be xray compatible trace Id #24389

Closed
dluongiop opened this issue Jul 19, 2023 · 5 comments
Closed
Labels

Comments

@dluongiop
Copy link

dluongiop commented Jul 19, 2023

Component(s)

exporter/awsxray

Is your feature request related to a problem? Please describe.

We are using the awsxray exporter to send traces to AWS X-Ray backend but the exporter is not able to translate the span from OTLP format due to invalid xray trace id.

Other people have encounter this problem: open-telemetry/opentelemetry-cpp#1259

Describe the solution you'd like

I think the awsxray exporter should generate a new xray trace id and incorporate the original trace id from OTLP into the xray trace format. This solution wouldn't require the client to generate the xray compatible trace id. Also the instrumentation library doesn't need to change to accommodate this.

Describe alternatives you've considered

No response

Additional context

No response

@dluongiop dluongiop added enhancement New feature or request needs triage New item requiring triage labels Jul 19, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dhilgarth
Copy link

@dluongiop

The issue with this is that X-Ray requires the first 8 hex digits to be a timestamp, specifically the timestamp at which the trace was started.
In a distributed system, you don't have this info at every point in the system and it's therefore impossible to create a valid X-Ray ID from a trace ID without having the complete trace available.

@srprash
Copy link
Contributor

srprash commented Jul 31, 2023

@dhilgarth is right, and that's why it is must for the x-ray format trace id to be generated in the instrumentation.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • exporter/awsxray: @wangzlei @srprash
  • needs: Github issue template generation code needs this to generate the corresponding labels.

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Oct 2, 2023
@crobert-1
Copy link
Member

From comments, I'm going to close this issue as this requested functionality is not possible. Please let me know if I've misunderstood.

@crobert-1 crobert-1 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2023
@crobert-1 crobert-1 removed the needs triage New item requiring triage label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants