[internal/azure] Move cluster name discovery mechanism to an internal package

[dmitryax]

Extract the logic to fetch k8s.cluster.name from exporter/datadogexporter to internal/azure and use it in processor/resourcedetectionprocessor/internal/azure/aks.

See #29328 (comment) for more details

[github-actions]

Pinging code owners for exporter/datadog: @mx-psi @dineshg13 @liustanley @songy23 @mackjmr. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[jsirianni]

Sounds good, will take care of it.

[github-actions]

Pinging code owners for processor/resourcedetection: @Aneurysm9 @dashpole. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[jsirianni]

@dmitryax I was taking a look at this and I am wondering where the new package should live? I cannot call resource detection's parse cluster name function (after exporting it) as it is part of an internal package.

package github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datadogexporter/internal/hostmetadata/internal/azure
	provider.go:14:2: use of internal package github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor/internal/azure/aks not allowed

Also, there are small differences between the two implementations. Resource detection is stricter and requires exactly four values after splitting the string. Datadog's implementation returns an error. Error handling won't be an issue but I am concerned about modifying datadog's cluster name handling.

[dmitryax]

It should be a new module called azure inside https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/internal. It'll be available for all the packages in this repo.

Try to consolidate the logic in a way that makes sense and let DataDog folks to review

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/datadog: @mx-psi @dineshg13 @liustanley @songy23 @mackjmr
• processor/resourcedetection: @Aneurysm9 @dashpole

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been closed as inactive because it has been stale for 120 days with no activity.