Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collectd receiver is not writing anything to debug log on start #31593

Closed
cforce opened this issue Mar 5, 2024 · 13 comments
Closed

collectd receiver is not writing anything to debug log on start #31593

cforce opened this issue Mar 5, 2024 · 13 comments

Comments

@cforce
Copy link

cforce commented Mar 5, 2024

Component(s)

receiver/collectd

Is your feature request related to a problem? Please describe.

When debugging if collectd is properly configured and loading i would epect an logs in debug level.

Describe the solution you'd like

Collectd shall report as loaded receiver plugin and on what host and port it is serving

Describe alternatives you've considered

No response

Additional context

No response

@cforce cforce added enhancement New feature or request needs triage New item requiring triage labels Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@cforce cforce changed the title collectd receiver is not writing anything to debug logs on start collectd receiver is not writing anything to debug log on start Mar 5, 2024
@crobert-1
Copy link
Member

Sounds like a valid enhancement to me. I did a quick scan of the receiver and didn't see any log messages that describe this information. Removing needs triage.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Mar 5, 2024
@atoulme
Copy link
Contributor

atoulme commented Mar 6, 2024

Sure, would you like to offer a patch?

@kernelpanic77
Copy link
Contributor

@atoulme @crobert-1 Can I take this up ?

@kernelpanic77
Copy link
Contributor

@atoulme @crobert-1 Can we discuss this issue in the weekly SIG ?

@crobert-1
Copy link
Member

Do you have a specific question or problem you're wanting to discuss?

@kernelpanic77
Copy link
Contributor

kernelpanic77 commented Mar 20, 2024

@crobert-1 I am a bit unsure if understood the problem correctly. From what I understood only the ServeHTTP method of the collectdReceiver struct has to be changed to add the debug logs for Host and Port.

Collectd shall report as loaded receiver plugin

Also, @atoulme @crobert-1 Could you also explain this requirement in a little more detail ?

@atoulme
Copy link
Contributor

atoulme commented Mar 20, 2024

FWIW you can always come to a SIG meeting and ask any question. In this instance, it feels like something we can resolve over Github.

Yes, I believe you are correct, just need to add a bit of logging in that method.

@kernelpanic77
Copy link
Contributor

kernelpanic77 commented Mar 20, 2024

FWIW you can always come to a SIG meeting

Sure @atoulme

Collectd shall report as loaded receiver plugin

I am not sure if I understood this sentence correctly. Could you explain this part ?

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label May 20, 2024
@crobert-1 crobert-1 removed the Stale label May 20, 2024
@atoulme
Copy link
Contributor

atoulme commented May 20, 2024

I am not sure if I understood this sentence correctly. Could you explain this part ?

Just that the receiver started ok. As in, it reports in debug in the Start method that it started.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 22, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants