Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider the need for specifying otelcol_version in builder manifest #31623

Closed
mx-psi opened this issue Mar 6, 2024 · 4 comments
Closed

Reconsider the need for specifying otelcol_version in builder manifest #31623

mx-psi opened this issue Mar 6, 2024 · 4 comments
Labels
cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol priority:p2 Medium release-retro Issues discussed in a release retrospective Stale

Comments

@mx-psi
Copy link
Member

mx-psi commented Mar 6, 2024

Component(s)

cmd/otelcontribcol, cmd/oteltestbedcol

Describe the issue you're reporting

During the 0.96.0 release I missed updating otelcol_version to 0.96.0, see #31551 (comment). @evan-bradley suggested we could remove otelcol_version entirely from the manifest and rely on the rest of core updates. Should we remove it?

@mx-psi mx-psi added priority:p2 Medium cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol release-retro Issues discussed in a release retrospective labels Mar 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label May 6, 2024
@mx-psi mx-psi removed the Stale label May 6, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jul 8, 2024
@mx-psi mx-psi removed the Stale label Jul 8, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Sep 9, 2024
@mx-psi
Copy link
Member Author

mx-psi commented Nov 5, 2024

Fixed by #11588

@mx-psi mx-psi closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol priority:p2 Medium release-retro Issues discussed in a release retrospective Stale
Projects
None yet
Development

No branches or pull requests

1 participant