-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce label to trigger load tests for a Pull Request #33979
Comments
/label ci-cd |
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I'd be up for working on this |
Sounds good to me, removing |
@crobert-1 @mx-psi PR is ready for review :) |
closing this since it's not feasible. more details in the attached PR |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the issue you're reporting
As discussed in this PR, we could introduce a label called "Run Load Tests" (similar to the "Run Windows" label) that triggers the load tests for a pull request.
This would make development and maintenance of the load tests much easier, since they only run on
main
right now, and also only on self-hosted runners.Right now, the load tests are fairly hard to maintain, since they are not fully reproducible for contributors, without access to the same self-hosted runners and the
main
branch limitation which doesn't run on PRs. Especially so, since the tests take hardware consumption into account as well, which differs between self-hosted and github-hosted runners (I assume).The text was updated successfully, but these errors were encountered: