-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect the environment variable DOCKER_HOST
in resolving the endpoint
#35779
Labels
Comments
michaelsafyan
added
enhancement
New feature or request
needs triage
New item requiring triage
labels
Oct 14, 2024
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This was referenced Oct 15, 2024
This was referenced Oct 29, 2024
@jamesmoessis any take on this request for enhancement? |
@atoulme @michaelsafyan it makes sense to me, would be happy to review |
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component(s)
receiver/dockerstats
Is your feature request related to a problem? Please describe.
The
dockerstatsreceiver
by default usesunix:///var/run/docker.sock
. Although the configuration supports overridding theendpoint
with something other than the default, it should not be necessary to specify the endpoint explicitly when the environment variableDOCKER_HOST
has been defined, pointing to the correct location.Note that the Docker documentation defines
DOCKER_HOST
as the "Daemon socket to connect to":There may be certain environments where the environment variable
DOCKER_HOST
has been set correctly to a non-standard endpoint and where it is difficult to modify thedockerstatsreceiver
config. For those situations, respectingDOCKER_HOST
for the default endpoint would be ideal.Describe the solution you'd like
The docker endpoint should be resolved in the following order:
endpoint
if it is set in the YAML config for the receiver.DOCKER_HOST
if it is set.unix:///var/run/docker.sock
Describe alternatives you've considered
Run a script to modify the
endpoint
in the YAML from the${DOCKER_HOST}
value.Additional context
No response
The text was updated successfully, but these errors were encountered: