Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receiver/prometheus, exporter/prometheus: recognize SIGHUP to reload configurations as Prometheus server does #4746

Closed
odeke-em opened this issue Aug 7, 2021 · 3 comments
Labels

Comments

@odeke-em
Copy link
Member

odeke-em commented Aug 7, 2021

Prometheus' server recognizes uses a SIGHUP signal sent to it, to reload configurations when they are changed.
Essentially Prometheus says per https://prometheus.io/docs/prometheus/latest/configuration/configuration/
Prometheus can reload configurations by sending SIGHUP or by visiting the /-/reload endpoint with —web.enable-lifecycle flag is enabled
Screen Shot 2021-08-06 at 11 47 15 PM

This means that we don't have parity with Prometheus server.

We filed this issue open-telemetry/prometheus-interoperability-spec#3 to implement parity with Prometheus server.

There is an old open issue from August 2019 (2 years ago) to support reload of configurations per open-telemetry/opentelemetry-collector#273 for the entire collector. Perhaps we should also add the general ability for the OpenTelemetry collector to reload every configuration if given a SIGHUP signal.

Please note that this issue isn't a release blocker

@bogdandrutu
Copy link
Member

I don't think this is a bug. we are not copying prometheus in this project. We do have other ways to reload config see the ConfigSource and other mechanisms.

@bogdandrutu bogdandrutu transferred this issue from open-telemetry/opentelemetry-collector Aug 20, 2021
@alolita alolita added the comp:prometheus Prometheus related issues label Sep 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 4, 2022
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants