Track the conversion of the benchmark to a real benchmark in skywalking exporter.

[liqiangz]

Refer to #5690. This issue is to track the benchmark of skywalking exporter.

[liqiangz]

@jpkrohling the issue has been created.

[vasireddy99]

@liqiangz Can you please provide more inputs about steps to track, I would like to give it a try :)

[jpkrohling]

Sure! This file contains a test that is measuring the time it takes for some operations:

exporter/skywalkingexporter/skywalking_benchmark_test.go

This thread is relevant for this task: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/5690/files#r739082935

Ideally, we would be using real Go benchmarks, as described here: https://pkg.go.dev/testing#hdr-Benchmarks

If benchmarking that isn't straightforward (I think it should), that source file should just be removed. The goal for that test is to assess that concurrent calls to pushLogs benefit from the implementation having a connection pooling mechanism like this:

opentelemetry-collector-contrib/exporter/skywalkingexporter/skywalking.go

Lines 100 to 113 in 1e9005e

	tClient, ok := <-oce.logsClients
	if !ok {
	return errors.New("failed to push logs, Skywalking exporter was already stopped")
	}
	if tClient == nil {
	var err error
	tClient, err = oce.createLogServiceRPC()
	if err != nil {
	// Cannot create an RPC, put back nil to keep the number of streams constant.
	oce.logsClients <- nil
	return err
	}
	}

[vasireddy99]

Hi @alolita, Please assign this to me. I would like to start working on this.

[jpkrohling]

Assigned.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

[github-actions]

Pinging code owners: @liqiangz. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/skywalking: @liqiangz

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[jpkrohling]

@liqiangz, are you still the code owner for the component?

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• exporter/skywalking: @liqiangz

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[liqiangz]

@liqiangz, are you still the code owner for the component?

please assign to me

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• issue: Github issue template generation code needs this to generate the corresponding labels.
• exporter/skywalking: @liqiangz

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been closed as inactive because it has been stale for 120 days with no activity.

[jpkrohling]

@wu-sheng , any chance we can get this done?

[wu-sheng]

@liqiangz Are you still on this?

@jpkrohling I have no update about this too.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

[jpkrohling]

Given that the component will be removed soon, this should be closed.