Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review public methods of prometheus remote write exporter #7294

Closed
codeboten opened this issue Jan 20, 2022 · 4 comments · Fixed by #7295
Closed

Review public methods of prometheus remote write exporter #7294

codeboten opened this issue Jan 20, 2022 · 4 comments · Fixed by #7295
Assignees
Labels
comp: exporter Exporter comp:prometheus Prometheus related issues exporter/awsprometheusremotewrite AWS PRW exporter related issues

Comments

@codeboten
Copy link
Contributor

When updating the code for #7283 I noticed the prometheus remote write exporter appears to be exposing more methods than other exporters. Is this necessary? if not I propose make the following private:


func NewPRWExporter(cfg *Config, buildInfo component.BuildInfo) (*PRWExporter, error) {

@codeboten
Copy link
Contributor Author

@Aneurysm9 you may know more about this as the code owner for both the prometheusremotewrite and the awsprometheusremotewrite exporters.

@jpkrohling
Copy link
Member

cc @gouthamve

@alolita
Copy link
Member

alolita commented Jan 20, 2022

@codeboten we (my team) had built this exporter and will take a look at its design. Please add @Aneurysm9 as the owner for this review.

@alolita alolita added exporter/awsprometheusremotewrite AWS PRW exporter related issues comp:prometheus Prometheus related issues comp: exporter Exporter labels Jan 20, 2022
@Aneurysm9 Aneurysm9 self-assigned this Jan 20, 2022
@Aneurysm9
Copy link
Member

It looks safe to change the visibility of these methods. The AWS PRW exporter only relies on Config and NewFactory(). I'll get a PR up shortly if the full test suite passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: exporter Exporter comp:prometheus Prometheus related issues exporter/awsprometheusremotewrite AWS PRW exporter related issues
Projects
None yet
4 participants