Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/splunkhec] Ensure Validate implementation does the right thing #7844

Closed
codeboten opened this issue Feb 11, 2022 · 1 comment · Fixed by #8256
Closed

[exporter/splunkhec] Ensure Validate implementation does the right thing #7844

codeboten opened this issue Feb 11, 2022 · 1 comment · Fixed by #8256
Labels
comp:splunk Splunk components good first issue Good for newcomers help wanted Extra attention is needed

Comments

@codeboten
Copy link
Contributor

This change in the collector core added a Validate method to QueueSettings which caused ambiguity with the ExporterSettings’ Validate method. As a result, I’ve added a Validate method to this exporter and an issue to ensure it was doing the right thing.

Here is an example of the validate method for the OTLP exporter calling the QueueSettings’ Validate

open-telemetry/opentelemetry-collector@48c402d#diff-a56037437974f775001642d59880ac9dd0c14cab137576b4f4a6df01a230a84cR39-R42

Originally posted by @codeboten in #7779 (comment)
@codeboten codeboten added help wanted Extra attention is needed good first issue Good for newcomers comp:splunk Splunk components labels Feb 11, 2022
@jpkrohling
Copy link
Member

cc @atoulme @dmitryax

@JaredTan95 JaredTan95 mentioned this issue Mar 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:splunk Splunk components good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[exporter/splunkhec] Add validation for sending_queue setting
2 participants
@jpkrohling @codeboten