Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prometheusremotewriteexporter] TraceID and SpanID must be added as exemplar attributes. #8351

Closed
dashpole opened this issue Mar 9, 2022 · 0 comments · Fixed by #8380
Closed

[prometheusremotewriteexporter] TraceID and SpanID must be added as exemplar attributes. #8351

dashpole opened this issue Mar 9, 2022 · 0 comments · Fixed by #8380
Assignees
@dashpole
Labels
comp:prometheus Prometheus related issues enhancement New feature or request spec:metrics

Comments

@dashpole
Copy link
Contributor

dashpole commented Mar 9, 2022

Description
In the code converting exemplars for PRW, we don't do anything with the attached trace ID or span ID

As described in the prometheus conversion spec, prometheus exporters must attach trace_id and span_id to prometheus exemplars
@dashpole dashpole added enhancement New feature or request comp:prometheus Prometheus related issues labels Mar 9, 2022
@dashpole dashpole changed the title [prometheusremotewriteexporter] TraceID and SpanID should be added as exemplar attributes. [prometheusremotewriteexporter] TraceID and SpanID must be added as exemplar attributes. Mar 9, 2022
@dashpole dashpole self-assigned this Mar 10, 2022
@dashpole dashpole mentioned this issue Mar 10, 2022
Merged
@dashpole dashpole mentioned this issue Jun 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashpole dashpole

Labels
comp:prometheus Prometheus related issues enhancement New feature or request spec:metrics
Projects
None yet
Milestone
No milestone
1 participant
@dashpole