Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace mock traces exporter with consumertest.TracesSink #9123

Closed
jpkrohling opened this issue Apr 8, 2022 · 3 comments
Closed

Replace mock traces exporter with consumertest.TracesSink #9123

jpkrohling opened this issue Apr 8, 2022 · 3 comments

Comments

@jpkrohling
Copy link
Member

I think we have a test facility native to the collector that we could use, right? Doesn't have to be changed on this PR, but perhaps it would make sense to open an issue to track this?

Originally posted by @jpkrohling in #8990 (comment)
@jpkrohling
Copy link
Member Author

This is the facility I had in mind: https://github.com/open-telemetry/opentelemetry-collector/blob/main/consumer/consumertest/sink.go#L25-L45

@jpkrohling jpkrohling mentioned this issue Apr 11, 2022
Closed
@mx-psi
Copy link
Member

mx-psi commented Jul 21, 2022

Sounds like this can be closed?

@jpkrohling
Copy link
Member Author

I believe so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpkrohling @mx-psi