[receiver/mongodbatlasreceiver] add metrics project config #28866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehaansa
reviewed
Nov 3, 2023
fatsheep9146
reviewed
Nov 3, 2023
fatsheep9146
reviewed
Nov 3, 2023
|
Hey @dehaansa and @fatsheep9146 , PR feedback has been applied and it is ready to be looked at again! Thanks 🙏 |
dehaansa
approved these changes
Nov 7, 2023
fatsheep9146
approved these changes
Nov 8, 2023
|
@djaglowski could you help review this pr? |
JonathanWamsley
force-pushed
the
mongodbatlasreceiver-add-metrics-project-config
branch
from
fad2fcd to
e8ea275
Compare
djaglowski
reviewed
Nov 14, 2023
JonathanWamsley
force-pushed
the
mongodbatlasreceiver-add-metrics-project-config
branch
from
e8ea275 to
0ccc082
Compare
djaglowski
reviewed
Nov 16, 2023
JonathanWamsley
force-pushed
the
mongodbatlasreceiver-add-metrics-project-config
branch
from
91ab449 to
ab0ba87
Compare
djaglowski
reviewed
Nov 16, 2023
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
djaglowski
approved these changes
Nov 17, 2023
graphaelli
pushed a commit
to graphaelli/opentelemetry-collector-contrib
that referenced
this pull request
Nov 17, 2023
…metry#28866) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This feature adds a Project Config for the metrics to filter by Project name and or clusters. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#28865 **Testing:** <Describe what testing was performed and which tests were added.> - Added test for cluster filtering - Tested project name alone, project name with IncludeClusters and project name with ExcludeClusters on a live environment with success. **Documentation:** <Describe the documentation added.> Added optional project config fields to README --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
aishyandapalli
pushed a commit
to aishyandapalli/opentelemetry-collector-contrib
that referenced
this pull request
Nov 17, 2023
…metry#28866) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This feature adds a Project Config for the metrics to filter by Project name and or clusters. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#28865 **Testing:** <Describe what testing was performed and which tests were added.> - Added test for cluster filtering - Tested project name alone, project name with IncludeClusters and project name with ExcludeClusters on a live environment with success. **Documentation:** <Describe the documentation added.> Added optional project config fields to README --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…metry#28866) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This feature adds a Project Config for the metrics to filter by Project name and or clusters. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#28865 **Testing:** <Describe what testing was performed and which tests were added.> - Added test for cluster filtering - Tested project name alone, project name with IncludeClusters and project name with ExcludeClusters on a live environment with success. **Documentation:** <Describe the documentation added.> Added optional project config fields to README --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This feature adds a Project Config for the metrics to filter by Project name and or clusters.
Link to tracking Issue:
#28865
Testing:
Documentation:
Added optional project config fields to README